Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown toggle z-index in LCARS theme #2405

Merged
merged 1 commit into from Oct 18, 2022
Merged

Conversation

egad13
Copy link
Contributor

@egad13 egad13 commented Oct 17, 2022

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

This PR aims to fix a small CSS issue in the LCARS theme which causes dropdown toggle buttons to render on top of the actual dropdowns, which causes dropdowns to be nigh-unusable on pages which have multiple close-together dropdown toggles, such as Clients or Adlists.

Example from the Domains page:
Pi-hole web interface domains tab, showing the dropdown for one domain's group assignment rendering underneath the toggle buttons for subsequent domains.

  • How does this PR accomplish the above?:

The z-index of the .dropdown-toggle selector was changed to be just below that of the dropdowns (selector .bootstrap-select.bs-container .dropdown-menu in /styles/vendor/bootstrap-select.min.css), so they render in the right order.

  • What documentation changes (if any) are needed to support this PR?:

None


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: egad13 <egad.coding@gmail.com>
@yubiuser yubiuser merged commit 76bf7d7 into pi-hole:devel Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants