Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index of .dropdown-toggle #2474

Merged
merged 1 commit into from Dec 31, 2022

Conversation

infinitytec
Copy link
Contributor

@infinitytec infinitytec commented Dec 31, 2022

A recent fix seemed to improve this but by going a bit further it seems to resolve the problem where the dropdown-toggle buttons would appear over alert messages.

Signed-off-by: infinitytec infinitytec@users.noreply.github.com

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

This PR fixes some z-index issues with the .dropdown-toggle buttons that causes them to appear over pop-up alerts in the LCARS theme.

It is difficult to get a screenshot due to the brief visibility of the alert.

How does this PR accomplish the above?:

I further adjusted the z-index like was done in #2405

Link documentation PRs if any are needed to support this PR:

None.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

rdwebdesign
rdwebdesign previously approved these changes Dec 31, 2022
@rdwebdesign
Copy link
Member

I could replicate the issue.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to and target devel branch.

@infinitytec infinitytec changed the base branch from master to devel December 31, 2022 21:16
@infinitytec infinitytec dismissed rdwebdesign’s stale review December 31, 2022 21:16

The base branch was changed.

@infinitytec
Copy link
Contributor Author

infinitytec commented Dec 31, 2022

Please rebase to and target devel branch.

I think I got this changed. Let me know if I did it wrong.

A recent fix seemed to improve this but by going a bit further it seems to resolve the problem where the dropdown-toggle buttons would appear over alert messages.

Signed-off-by: infinitytec <infinitytec@users.noreply.github.com>
@rdwebdesign rdwebdesign merged commit e1ea3df into pi-hole:devel Dec 31, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-1-web-v5-18-1-and-core-v5-15-released/60495/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants