Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard for better fit of small boxes #859

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Update dashboard for better fit of small boxes #859

merged 1 commit into from
Nov 1, 2018

Conversation

KrunchMuffin
Copy link
Contributor

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • [] I have made only one major change in my proposed changes.
  • [] I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • [] I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:
Better readability of the dashboard on small and medium devices

{A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues}
On the raspberrypi official touchscreen (and other screens that fit "small" and "medium"), the small boxes take up the 12 columns which forces to scroll and is generally ineffective as a quick glance dashboard.

How does this PR accomplish the above?:
I have updated to col-sm-6 so there are 2 boxes on 2 rows so now you can see all those stats plus the queries last 24 without having to scroll. the col-xs-12 is not necessary as it will default to that.
{A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix}

What documentation changes (if any) are needed to support this PR?:
NONE

{A detailed list of any necessary changes}
updated to col-sm-6 from col-xs-12

@AzureMarker
Copy link
Contributor

AzureMarker commented Oct 27, 2018

Can you add screenshots of before and after on the affected screen sizes?

@KrunchMuffin
Copy link
Contributor Author

Sure. Don't know how to do screenshots on RPi, so took pic if that's OK?
2018-10-27 15 48 39
2018-10-27 15 46 55

AzureMarker
AzureMarker previously approved these changes Oct 31, 2018
@AzureMarker
Copy link
Contributor

@KrunchMuffin follow the instructions in the DCO check to sign-off your commit.

On the raspberrypi official touchscreen (and other screens that fit "small" and "medium"), the small boxes take up the 12 columns which forces to scroll and is generally ineffective as a quick glance dashboard. I have updated to col-sm-6 so there are 2 boxes on 2 rows so now you can see all those stats plus the queries last 24 without having to scroll. the col-xs-12 is not necessary as it will default to that.

Signed-off-by: Derek Bowes <db@bowesmail.com>
@KrunchMuffin
Copy link
Contributor Author

Sign off done

@AzureMarker AzureMarker merged commit a072c53 into pi-hole:devel Nov 1, 2018
@KrunchMuffin KrunchMuffin deleted the patch-1 branch December 12, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants