Remove some unnecessary string concatenation from CertificatePal.Appe…

…ndPrivateKeyInfo (dotnet/corefx#41274) Commit migrated from dotnet/corefx@f2292af
picenka21 · Sep 24, 2019 · 6802085 · 6802085
1 parent 743d65b
commit 6802085
Showing 1 changed file with 12 additions and 22 deletions.
diff --git a/...ity.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.Windows/CertificatePal.cs b/...ity.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.Windows/CertificatePal.cs
@@ -423,48 +423,38 @@ public void AppendPrivateKeyInfo(StringBuilder sb)
             if (cspKeyContainerInfo == null)
                 return;
 
-            sb.Append(Environment.NewLine + "  Key Store: ");
-            sb.Append(cspKeyContainerInfo.MachineKeyStore ? "Machine" : "User");
-            sb.Append(Environment.NewLine + "  Provider Name: ");
-            sb.Append(cspKeyContainerInfo.ProviderName);
-            sb.Append(Environment.NewLine + "  Provider type: ");
-            sb.Append(cspKeyContainerInfo.ProviderType);
-            sb.Append(Environment.NewLine + "  Key Spec: ");
-            sb.Append(cspKeyContainerInfo.KeyNumber);
-            sb.Append(Environment.NewLine + "  Key Container Name: ");
-            sb.Append(cspKeyContainerInfo.KeyContainerName);
+            sb.AppendLine().Append("  Key Store: ").Append(cspKeyContainerInfo.MachineKeyStore ? "Machine" : "User");
+            sb.AppendLine().Append("  Provider Name: ").Append(cspKeyContainerInfo.ProviderName);
+            sb.AppendLine().Append("  Provider type: ").Append(cspKeyContainerInfo.ProviderType);
+            sb.AppendLine().Append("  Key Spec: ").Append(cspKeyContainerInfo.KeyNumber);
+            sb.AppendLine().Append("  Key Container Name: ").Append(cspKeyContainerInfo.KeyContainerName);
 
             try
             {
                 string uniqueKeyContainer = cspKeyContainerInfo.UniqueKeyContainerName;
-                sb.Append(Environment.NewLine + "  Unique Key Container Name: ");
-                sb.Append(uniqueKeyContainer);
+                sb.AppendLine().Append("  Unique Key Container Name: ").Append(uniqueKeyContainer);
             }
             catch (CryptographicException) { }
             catch (NotSupportedException) { }
 
-            bool b = false;
             try
             {
-                b = cspKeyContainerInfo.HardwareDevice;
-                sb.Append(Environment.NewLine + "  Hardware Device: ");
-                sb.Append(b);
+                bool b = cspKeyContainerInfo.HardwareDevice;
+                sb.AppendLine().Append("  Hardware Device: ").Append(b);
             }
             catch (CryptographicException) { }
 
             try
             {
-                b = cspKeyContainerInfo.Removable;
-                sb.Append(Environment.NewLine + "  Removable: ");
-                sb.Append(b);
+                bool b = cspKeyContainerInfo.Removable;
+                sb.AppendLine().Append("  Removable: ").Append(b);
             }
             catch (CryptographicException) { }
 
             try
             {
-                b = cspKeyContainerInfo.Protected;
-                sb.Append(Environment.NewLine + "  Protected: ");
-                sb.Append(b);
+                bool b = cspKeyContainerInfo.Protected;
+                sb.AppendLine().Append("  Protected: ").Append(b);
             }
             catch (CryptographicException) { }
             catch (NotSupportedException) { }