-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed Xcode 14 build error #1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm personally that this merge fixes this issue: #1216
@pichillilorenzo would you please review and merge this in? Right now, in the XCode beta, I have to manually edit the package file. |
Merge it, Works on XCode 14 Beta 4 |
ios/Classes/Types/UserScript.swift
Outdated
@@ -10,8 +10,19 @@ import WebKit | |||
|
|||
public class UserScript : WKUserScript { | |||
var groupName: String? | |||
|
|||
var contentWorldWrapper: Any? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to make this variable private bacause it's a detail of implementation
lazy var contentWorld: WKContentWorld = WKContentWorld.page | ||
var contentWorld: WKContentWorld { | ||
get { | ||
if let value = contentWorldWrapper as? WKContentWorld { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep lazy behaviour i'd suggest the following implementation
if contentWorldWrapper == nil {
contentWorldWrapper = WKContentWorld.page
}
return contentWorldWrapper as! WKContentWorld
, but yours is safer
When will this be merged? |
When will this be merged? |
1 similar comment
When will this be merged? |
Until it is merged you can use
and then run the following command
|
Please merge it |
@cimplesid boss |
Please merge it, it works for me too |
@pichillilorenzo Please merge it |
Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:
|
Thanks, Buddy :) |
Thank you. İts workly ! |
Any ETA as to when will this fix be merged? RN I need to add the dependency override to allow a build on iOS, but it breaks the build on Android, so I have to constantly go back and forth with adding/removing it. |
What is the ETA on when this fix be merged?? Currently i am not able build the app for iOS without this fix. |
Another workaround: Set deployment target for pods and project to iOS 14. May or may not be a good workaround for you, just dropping it here. It's a good one for me, because I need WASM support from inapp_webview, and on iOS the earliest version of iOS that supports WASM in JavaScriptCore is iOS 14. So now I have 2 reasons to require 14 as the minimum version. Previously the app would show an error dialog asking users to upgrade, now it just won't run at all on 13 and below. |
Please merge this. I would appreciate not implementing in a workaround when the solution exists! |
This PR fix solved it for us too. |
Merge, please..... |
This is a blocker and should be fixed ASAP. |
It works |
Also blocked a release for my app. Please merge it |
This is also a blocker for an app release for me. We have a small user base, and we are required to support older versions of iOS. Please merge. Note, we are dependent on this because we use youtube_player_flutter. |
@pichillilorenzo let's get this merged! |
Plz merge it! |
Please merge it. |
Released new version |
Connection with issue(s)
Resolve issue #1216
Connected to #1216
Testing and Review Notes
Screenshots or Videos
To Do