Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directoryIndex and documentRoot to InAppLocalhostServer option #1319

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

fa0311
Copy link
Contributor

@fa0311 fa0311 commented Sep 15, 2022

Connection with issue(s)

How is the feature useful

Less hassle when loading existing html for websites.

Testing and Review Notes

final InAppLocalhostServer localhostServer = InAppLocalhostServer(
  port: 8080,
  documentRoot: "./assets/website/",
  directoryIndex: "index.html",
);

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@pichillilorenzo pichillilorenzo merged commit ecd126c into pichillilorenzo:master Oct 13, 2022
@pichillilorenzo
Copy link
Owner

Thanks! @all-contributors please add @fa0311 for code

@allcontributors
Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @fa0311! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants