Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unobtrusive Fork of Guiders.js #85

Closed
tarr11 opened this issue Jan 18, 2013 · 4 comments
Closed

Unobtrusive Fork of Guiders.js #85

tarr11 opened this issue Jan 18, 2013 · 4 comments

Comments

@tarr11
Copy link

tarr11 commented Jan 18, 2013

I've forked guiders to have an "unobtrusive version". The idea is to write most of your guiders in html5 instead of JS.

If this is interesting enough, i could clean up the code and issue a pull request into the main project.

Demo

Repo
@pickhardt
Copy link
Owner

Please do, I have always wanted this too! This has always been in the back
of my mind as something I've wanted, because it'd be cleaner. If you make a
pull request, I will merge this into the main branch! Thanks!

Also, I like CorpQNA. I could've really used something like that before.

Jeff Pickhardt
pickhardt@gmail.com

On Fri, Jan 18, 2013 at 11:20 AM, Douglas Tarr notifications@github.comwrote:

I've forked guiders to have an "unobtrusive version". The idea is to write
most of your guiders in html5 instead of JS.

If this is interesting enough, i could clean up the code and issue a pull
request into the main project.

Demo http://tarr11.github.com/guiders.unobtrusive.js/demo.html

Repo https://github.com/tarr11/guiders.unobtrusive.js

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/85.

@pickhardt
Copy link
Owner

Hi Doug,

Is this:
https://github.com/tarr11/guiders.unobtrusive.js/blob/master/guiders.unobtrusive.js

The entire diff of your changes?

I'd like to include this in a new version I'm working on. I like what you
did.

Thanks,
Jeff

On Fri, Jan 18, 2013 at 12:26 PM, Jeff Pickhardt pickhardt@gmail.comwrote:

Please do, I have always wanted this too! This has always been in the
back of my mind as something I've wanted, because it'd be cleaner. If you
make a pull request, I will merge this into the main branch! Thanks!

Also, I like CorpQNA. I could've really used something like that before.

Jeff Pickhardt
pickhardt@gmail.com

On Fri, Jan 18, 2013 at 11:20 AM, Douglas Tarr notifications@github.comwrote:

I've forked guiders to have an "unobtrusive version". The idea is to
write most of your guiders in html5 instead of JS.

If this is interesting enough, i could clean up the code and issue a pull
request into the main project.

Demo http://tarr11.github.com/guiders.unobtrusive.js/demo.html

Repo https://github.com/tarr11/guiders.unobtrusive.js

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/85.

@tarr11
Copy link
Author

tarr11 commented Jan 26, 2013

Yes, that was it really.

There's also a demo.html file but that's not really a big deal. I don't know if I got all the properties though, just enough for a proof of concept.

I also felt like I put some of the properties at the wrong (child) level - it was sorely in need of defaults on the parent. But if you want to write / skip that stuff it's fine w me.

I probably wouldn't be able to get to it for another week or so.

@pickhardt
Copy link
Owner

Closing this because I've added support for this in the dev branch.

spmason pushed a commit to spmason/Guiders-JS that referenced this issue Dec 4, 2013
@pickhardt
First commit of the dev branch and beginning of version 2.0.0! Change…
1b8bb32 
…log:

- Started keeping a changelog in changelog.txt.
- Since this is a major change, I am incrementing the version number to 2.0.0. (Following Semantic Versioning, http://semver.org/)
- Created a dev branch on GitHub. (https://github.com/jeff-optimizely/Guiders-JS/tree/dev) Contributors, issue pull requests to the dev branch so I can safely pull them without worrying about screwing up master code.
- Changed the file names from guiders-(version).js and guiders-(version).css to simply guiders.js and guiders.css, so that it's easier to track changes in GitHub. If you want to know what version you have, just open the file or check guiders.version.
- Upgraded jQuery from 1.51 to 1.90. It should still work with older versions of jQuery.
- Use var guiders = this.guiders = {}; instead of var guiders = (function() { ... }) in order for guiders to attach to the window object more reliably. (Thanks @spmason 7229f66#commitcomment-2506855)
- Added bower support in component.json (Thanks rajkissu pickhardt#78)
- Added a method: guiders.getCurrentGuider, to get the current guider. This can be useful for analytics tracking, for example.
- guiders.next and guiders.prev return the value of guiders.getCurrent()
- Allow creating guidres in the HTML, then creating guiders via $("#guider2").guider(options).  The options can be passed in through options or set as data-attrs on the object in the HTML. (Thanks @tarr11 pickhardt#85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarr11 @pickhardt