Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickles is unable to deal with Danish characters #477

Merged
merged 14 commits into from
Aug 10, 2017

Conversation

s991116
Copy link

@s991116 s991116 commented Aug 3, 2017

Test with danish character ('æ', 'ø', 'å') is not found in test results.
The mapping of scenario-steps with these charaters are not mapped (eg. æ => ae)
Only danish characters are added to the SpecflowNameMapping.

@dirkrombauts
Copy link
Member

Thanks for this extension! Could you please provide unit tests as well? Thanks

@s991116
Copy link
Author

s991116 commented Aug 3, 2017 via email

@dirkrombauts
Copy link
Member

The test harness is a separate solution in the same repository. You need to install a few non-standard components for that, I'm afraid.

The Contributing.md should contain the info you need to get started. If there's something missing or unclear, please let me know so I can adapt it.

@s991116
Copy link
Author

s991116 commented Aug 3, 2017 via email

…s. (Cucumber, MsTest, NUnit, SpecRun, VsTest and XUnit). Test for Cucumber (Ruby) and CucumberJS is ignored. I havent been able to generate testresults (CucumberJson) for these scenarios.
@dirkrombauts
Copy link
Member

Thanks for the update! I'll have a look soon and see whether I can do something about the Ruby and JS results. If I can, I'll add them to your pull request.

@s991116
Copy link
Author

s991116 commented Aug 8, 2017

I'm not able to generate test-output for Cucumber (Ruby) and CucumberJS. The Json files are empty
I have added steps (MinimalSteps.js / MinimalSteps.rb), but I think it is not able to match the step-definition.

Regarding converting special characters, It could have been made more general, by using the converter from Specflow. You can see the code used in SpecFlow here

@dirkrombauts dirkrombauts changed the title Namemapping scenarios with Danish-character to test Make Pickles able to deal with Danish characters Aug 9, 2017
@dirkrombauts dirkrombauts changed the title Make Pickles able to deal with Danish characters Pickles is unable to deal with Danish characters Aug 9, 2017
@dirkrombauts
Copy link
Member

I got the Cucumber Ruby results to work, and I added an entry to the change log. I had to merge changes from the upstream develop branch.

The Cucumber JS test results are a bit of a mystery still - they don't work at all (the ruby ones only didn't pick up the Danish stuff). I'll need to investigate that more.

@s991116
Copy link
Author

s991116 commented Aug 9, 2017 via email

@s991116
Copy link
Author

s991116 commented Aug 10, 2017

Hi
Do you have an estimate on when a release with this change will be available?

@dirkrombauts
Copy link
Member

I hope to have something by the end of the week, but I can't guarantee anything. I can get the CucumberJS results to work with some manual editing, but I'd like to get to the bottom of it because otherwise the next time we change the test results we'll have the same issue.

@dirkrombauts dirkrombauts merged commit 6bb581d into picklesdoc:develop Aug 10, 2017
@dirkrombauts
Copy link
Member

Thanks for your contribution and patience. I hope to release a new version in the coming days, but you can compile your own from source in the meantime.

dirkrombauts added a commit that referenced this pull request Aug 13, 2017
* Pickles is unable to deal with Danish characters (#477)

* Version 2.16.2
@dirkrombauts
Copy link
Member

Released in version 2.16.2

dirkrombauts pushed a commit that referenced this pull request Apr 19, 2018
* Version 2.16.2 (#483)

* Pickles is unable to deal with Danish characters (#477)

* Version 2.16.2

* Version 2.17.0

* fix Scenario outline export

* correction clean the code and create specific class/function with testResults

* fix forgotten scripts after rename

* fix to valid tests
dirkrombauts pushed a commit that referenced this pull request Jun 15, 2018
* Version 2.16.2 (#483)

* Pickles is unable to deal with Danish characters (#477)

* Version 2.16.2

* Version 2.17.0

* Add technicalTags to exclude technical tags in report

but keep feature

* fix on tehcnicalTags

* add tests

* Version 2.18.1

* update property name to HideTags

* fix forgotten files following rename of property

* Verson 2.18.2

* fix to make hideTags work with scenario

* add params to avoid null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants