Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong config keys in discoverPageSiblings #675

Closed
zeleznypa opened this issue Sep 1, 2023 · 1 comment
Closed

Wrong config keys in discoverPageSiblings #675

zeleznypa opened this issue Sep 1, 2023 · 1 comment
Labels
status: Resolved type: Bug

Comments

@zeleznypa
Copy link

Rest of the code use pages_order and pages_order_by keys.

Pico/lib/Pico.php

Line 1889 in 09aa825

if (($this->getConfig('order_by') === 'date') && ($this->getConfig('order') === 'desc')) {

@PhrozenByte
Copy link
Collaborator

Good catch! 👍 A pull request on the pico-3.0 branch (even though it's clearly a bug, it still is a breaking change: people likely circumvented it by other means already) is very welcome.

dkyme added a commit to dkyme/Pico that referenced this issue Dec 30, 2023
@dkyme
fix Wrong config keys in discoverPageSiblings picocms#675
914dd94
@dkyme dkyme mentioned this issue Dec 30, 2023
Merged
PhrozenByte added a commit that referenced this issue Dec 30, 2023
@PhrozenByte
Merge pull request #686 from dkyme/fix-discoverPageSiblings
ae9a8eb 
fix Wrong config keys in discoverPageSiblings #675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: Resolved type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhrozenByte @zeleznypa