Extract dependencies to normal nuget references #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwensley
force-pushed
the
curtis/wpf-be-normal-nuget-eh
branch
from
58dd3a6
to
2231f4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be a good citizen, we should not be embedding nuget references. Doing this also simplifies extending handlers in Eto.Wpf and Eto.WinForms as you don't have to reference Extended.Wpf.Toolkit or WindowsAPICodePack manually.
Note that this means you'll get extra dll's when compiling for WPF or WinForms, but now you will have control over the version of said assemblies. 🎉