Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wpf: Fix CheckBoxCell not firing CellEdited events #1981

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

Sejsel
Copy link
Contributor

@Sejsel Sejsel commented Jul 9, 2021

CellEdited events were not fired if clicking the CheckBox and going through the OnMouseUp() override that helps skip the three required clicks (select, enter edit, click) because that does not end up going through the typical WPF edit path (and thus CommitCellEdit is not called).

Sejsel added a commit to gw2scratch/evtc that referenced this pull request Jul 9, 2021
Works around an Eto issue with missing events:
picoe/Eto#1981
@cwensley
Copy link
Member

Awesome! Thanks for the fix.

@cwensley cwensley merged commit fd115a2 into picoe:develop Jul 13, 2021
@cwensley cwensley added this to the 2.6.0 milestone Jul 13, 2021
@cwensley cwensley added the bug label Jul 13, 2021
Sejsel added a commit to gw2scratch/evtc that referenced this pull request Nov 30, 2021
Works around an Eto issue with missing events:
picoe/Eto#1981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants