Wpf: Fix endless update cycles due to odd DPIs and wrapped labels #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now only re-jig the layout if the desired height of a label is changed, vs. every time the width changes. In odd DPI sizes (e.g. 150%, 175%) the actual width of a label can get sizes different than assigned by the layout, which causes it to cycle layouts constantly going back and forth between two very similar widths.
Checking the desired height gets around this problem by only updating the preferred size when the height actually changes, which is why we were doing this to begin with. It is consequently more efficient and has fewer layout updates when resizing unless the number of lines in a label would actually change.