Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for print failure on non-UTF8 chars #84

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

hrobeers
Copy link
Contributor

Replace non-printable ASCII chars as love.graphics.print refuses to print non-UTF8 chars.

PICO-8 seems to have invented some non-UTF8 chars for icons.

This is a requirement to make fuz work:
Fuz Cartridge

To make most carts work, more changes are required, see my other PRs.
Or my workarounds branch: https://github.com/hrobeers/picolove/tree/workarounds

@Shoozza
Copy link
Member

Shoozza commented Jun 29, 2019

Thanks for the workaround, I'll try to add it with a few changes.

  • PICO-8 renders unknown chars as an empty space " ".
  • If there is an UTF8 char which uses multiple characters it will print space for each char (seems like there is no real UTF8 support).
  • Some chars cannot be used in PIC0-8 print, as it will generate an error (0x1a, 0x0d, 0x0a), they probably should do that in picolove as well

In the future a proper implementation should match that of PICO-8

@Shoozza Shoozza merged commit b21d6a7 into picolove:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants