Merge pull request #1028 from vktr/feature/fix-listen-interface-crash…

…-loop Sanity check listen interfaces and DHT bootstrap nodes
picotorrent · Nov 22, 2020 · ffba918 · ffba918
2 parents 280fe10 + 8f903cd
commit ffba918
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/picotorrent/bittorrent/session.cpp b/src/picotorrent/bittorrent/session.cpp
@@ -121,8 +121,15 @@ static lt::settings_pack getSettingsPack(std::shared_ptr<pt::Core::Configuration
         outfaces << "," << li.address;
     }
 
-    settings.set_str(lt::settings_pack::dht_bootstrap_nodes, dhtNodes.str().substr(1));
-    settings.set_str(lt::settings_pack::listen_interfaces, ifaces.str().substr(1));
+    if (dhtNodes.str().size() > 0)
+    {
+        settings.set_str(lt::settings_pack::dht_bootstrap_nodes, dhtNodes.str().substr(1));
+    }
+
+    if (ifaces.str().size() > 0)
+    {
+        settings.set_str(lt::settings_pack::listen_interfaces, ifaces.str().substr(1));
+    }
 
     if (outfaces.str().size() > 0)
     {