Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PicoTorrentCore cross-platform #230

Merged
merged 9 commits into from
Apr 8, 2016
Merged

Make PicoTorrentCore cross-platform #230

merged 9 commits into from
Apr 8, 2016

Conversation

vktr
Copy link
Member

@vktr vktr commented Mar 31, 2016

This is probably the biggest PR since we separated PicoTorrentCore and PicoTorrent. The basic idea behind this refactor is to make PicoTorrentCore cross-platform.

Here is the checklist,

  • Remove filesystem abstraction.
  • Move configuration and environment to the client.
  • Make the session class take a session_configuration instance to support configuring the session.
  • Generate the session_configuration from the client configuration.
  • Remove std::wstring dependency from PicoTorrentCore.
  • Add a Platform Adaption Layer (PAL) which abstracts the specific platform functions needed for PicoTorrentCore.
  • Add a PAL for Windows.
  • Move logging implementation to the client.
  • Add a Travis CI build which builds PicoTorrentCore only.
  • Reload session_configuration when the client saves its preferences.

Closes #149

@vktr vktr added the refactor label Mar 31, 2016
@vktr vktr changed the title [WIP] Make PicoTorrentCore cross-platform Make PicoTorrentCore cross-platform Apr 8, 2016
@vktr vktr merged commit b758de2 into picotorrent:develop Apr 8, 2016
@vktr vktr deleted the f/cross-platform-core branch April 8, 2016 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant