Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better preferences #899

Merged
merged 5 commits into from
Sep 14, 2020
Merged

Better preferences #899

merged 5 commits into from
Sep 14, 2020

Conversation

vktr
Copy link
Member

@vktr vktr commented Sep 12, 2020 •
edited
Loading

Rework preferences, including how we store them, display them, and other nice-to-haves.

  • Fix the width issue reported in Small width of preferences list #871
  • Rework the settings. Instead of having an int_value and string_value, move to a single value column and keep the settings JSON serialized. Also add a default_value to each setting (if any) which will let us introduce the Restore defaults button if anything goes wrong.
  • Restore default settings

@vktr vktr linked an issue Sep 12, 2020 that may be closed by this pull request
Small width of preferences list #871
Closed
@vktr vktr changed the title [WIP] Better preferences Better preferences Sep 13, 2020
@vktr vktr merged commit 1eb226d into picotorrent:master Sep 14, 2020
@vktr vktr deleted the feature/better-preferences branch September 14, 2020 07:28
@vktr vktr mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small width of preferences list
1 participant
@vktr