Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strict type error in Picqer\Financials\Exact\QueryFindable:findId #643

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix strict type error in Picqer\Financials\Exact\QueryFindable:findId #643

merged 1 commit into from
May 7, 2024

Conversation

i-shippi
Copy link
Contributor

Resolves #641

@i-shippi i-shippi mentioned this pull request Apr 22, 2024
Closed
DannyvdSluijs
DannyvdSluijs approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DannyvdSluijs DannyvdSluijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@stephangroen stephangroen merged commit 729c879 into picqer:main May 7, 2024
1 check passed
@i-shippi i-shippi deleted the fix-641 branch May 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyvdSluijs DannyvdSluijs DannyvdSluijs approved these changes

@remkobrenters remkobrenters remkobrenters approved these changes

Assignees

@stephangroen stephangroen

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strict type error
4 participants
@i-shippi @DannyvdSluijs @remkobrenters @stephangroen