Type, Primary key and inconsistency fixes #77
Conversation
…bers (like HID) can now be provided but guids are not yet supported.
…d without conversion as $code.
…d sometimes missing in $fillable. Added docblock to ReceivableList.
…ass is added as an alias because it is in the release.
| @@ -32,6 +32,8 @@ class Division extends Model | |||
| { | |||
|
|
|||
| use Query\Findable; | |||
|
|
|||
| protected $primaryKey = 'Code'; | |||
There was a problem hiding this comment.
Can you fix this indentation?
There was a problem hiding this comment.
Sorry just updated Komodo Edit will check its settings.
| class ReceivableList extends Model | ||
| { | ||
|
|
||
| use Query\Findable; | ||
|
|
||
| protected $primaryKey = 'HID'; |
There was a problem hiding this comment.
Can you fix this indentation?
| class_alias(__NAMESPACE__ . '\Transaction', __NAMESPACE__ . '\Transactions'); |
There was a problem hiding this comment.
You have created an extra class for backward compatibility here but have not done so for the Subscription* classes.
There was a problem hiding this comment.
As Subscriptions and SubscriptionTypes and SubscriptionLines are added recently added I dit not think this nessesary. Do you want me to add aliases for these classes as well?
There was a problem hiding this comment.
Since they are already released, we should. If you can do that, it would be great :)
There was a problem hiding this comment.
I don't see a use case that does not use the Autoloader so I could add a trigger_error statement with a depreciation warning. This way we can in the future clean up the extra files.
…hp and SubscriptionType.php. Added some properties to SubscriptionLine.
…m the Exact Online reference documentation when visiting the resource details pages. The generated php code includes the docblock, the primaryKey override (that is often forgotten) and is copy paste ready. The changes in the last commit are created with the script. Note: Only tested in Firefox with Greasemonkey but should work with Tampermonkey in chrome.
|
Thanks @kvij :) |
The second commit on findId is not that important to me so If you think the regex is overkill leave that out. I do use findId to resolve Division by HID and Exact does not like it when it is forced to be a string.
I am working on lazy loading the deferred but need consistent classnames for that (see lazyload branch). As most inconsistencies where posted recently (in entities that I use even) I wanted to push this out as soon as possible.
Please let me know if there is anything you disagree with.