Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mark v0.2.15 as major update #257

Closed
ostoc opened this issue Aug 18, 2017 · 16 comments
Closed

Should mark v0.2.15 as major update #257

ostoc opened this issue Aug 18, 2017 · 16 comments

Comments

@ostoc
Copy link

ostoc commented Aug 18, 2017

Because of the root font-size changed, will may affect REM based design. People need to be notified.

@ostoc ostoc changed the title Should update v0.2.15 as major update Should mark v0.2.15 as major update Aug 18, 2017
@mitchellhuang
Copy link

Also when is v0.2.16 coming out? I feel like there should be a hotfix cause I need the margin mixins to work. (See e1889c8). It's a pretty big bug.

@picturepan2
Copy link
Owner

picturepan2 commented Aug 19, 2017 via email

@picturepan2
Copy link
Owner

@ostoc Is it better to upgrade to 0.3.x branch?

@ostoc
Copy link
Author

ostoc commented Aug 19, 2017

@picturepan2 from my experience the new REM is not compatible with old version, and I spend few hours to change my all REM in the whole project. I am up for 0.3.x branch :)

@picturepan2
Copy link
Owner

@ostoc Sorry for that. I learn a lesson from this update.
Do you think there is a way to upgrade this kind of core things without making any trouble to others? Any better place for publishing the important change?

@picturepan2
Copy link
Owner

I am making the next release: v0.3.1.

@picturepan2
Copy link
Owner

@huangbong v0.3.1 is released https://github.com/picturepan2/spectre/releases/tag/v0.3.1. The utilities bug has been fixed.

@mitchellhuang
Copy link

@picturepan2 awesome! thanks! can you publish to npm? :)

@mitchellhuang
Copy link

I really should be maintaining my own version but I'm too lazy right now lol. Appreciate the fast turnaround!

@picturepan2
Copy link
Owner

@huangbong Done.

@mitchellhuang
Copy link

@picturepan2 FYI, the builds on cdnjs don't have the margin fix in. It's still padding. https://cdnjs.com/libraries/spectre.css

@dgdavid
Copy link

dgdavid commented Aug 21, 2017

Hi @picturepan2

Any better place for publishing the important change?

What about keep a changelog? ;)

BTW, great job. Thanks a lot.

@picturepan2
Copy link
Owner

@dgdavid Thank you. I will look on that soon.

@confusedmatrix
Copy link

confusedmatrix commented Aug 25, 2017

The dist/spectre.css file on the npm repo needs regenerating to include the margin/padding utility fix

@picturepan2
Copy link
Owner

@jooldesign Trying to fix it again.

@picturepan2
Copy link
Owner

@jooldesign Successfully updated with v0.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants