Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape the colons in the title #180

Merged
merged 13 commits into from
Sep 10, 2016
Merged

Conversation

peternewman
Copy link
Contributor

No description provided.

@Arachnid
Copy link
Contributor

Thanks again! Any interest in becoming a co-maintainer?

@Arachnid Arachnid merged commit ce052c0 into pidcodes:master Sep 10, 2016
@peternewman
Copy link
Contributor Author

Thanks for the offer @Arachnid but I think I'd rather concentrate on the existing open source stuff I'm involved in. Although by the time I've finished, your life should be easier, and the issues I've been fixing should be caught by a Travis job before they try and merge them.

My final end game, and the reason I'm doing this, is to get the data in a state where it can be used to update http://www.linux-usb.org/usb.ids and hence can be used in stuff like Wireshark https://github.com/wireshark/wireshark/blob/master/epan/dissectors/usb.c . Then I'll stop bothering you with all these PRs :).

@Arachnid
Copy link
Contributor

the issues I've been fixing should be caught by a Travis job before they try and merge them.

Yes, I've been meaning to set up CI, which would save me a lot of trouble with mundane issues (and prevent those you've identified as slipping through the cracks)

My final end game, and the reason I'm doing this, is to get the data in a state where it can be used to update http://www.linux-usb.org/usb.ids

Oh, that would be really excellent. Are you in a position to update the PID listing, too? Every time I tried submitting, the automated system rejected my diff, even though it applied cleanly when I tried it locally.

@peternewman
Copy link
Contributor Author

I was assuming the automated system would just work. Have you already got code to convert pid.codes into usb.ids then?

I generated a copy of the linux-usb website code here https://github.com/peternewman/usbids-original from their diff and the PCI IDs site. I think there was some stuff in their code suggesting you actually needed to register first now.

@Arachnid
Copy link
Contributor

Arachnid commented Sep 10, 2016

I was assuming the automated system would just work. Have you already got code to convert pid.codes into usb.ids then?

No, I was just talking about updating the single PID (edit: I meant VID) value, which is still set to its old owner. I tried composing a diff by hand, and while it applied locally, the email submission always failed.

peternewman added a commit to peternewman/pidcodes.github.com that referenced this pull request Sep 10, 2016
Escape the colons in the title (pidcodes#180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants