Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the markdown engine to kramdown as GitHub are getting rid of redcarpet :( #201

Merged
merged 24 commits into from
Dec 14, 2016

Conversation

peternewman
Copy link
Contributor

No description provided.

@peternewman
Copy link
Contributor Author

This bumps the starting list of broken links up to 15, as the ones in the body of pages are now turned into hyperlinks too.

@peternewman
Copy link
Contributor Author

This wants to go in before #200 so I can ignore or fix them there too.

@Arachnid
Copy link
Contributor

Arachnid commented Dec 8, 2016

Uhoh. I'm not sure this is going to work long-term. Github keeps sending me this:

The page build completed successfully, but returned the following warning:

You are currently using the 'redcarpet' Markdown engine, which is no longer supported by GitHub Pages and may cease working at any time. To ensure your site continues to build, remove the 'markdown' setting in your site's '_config.yml' file and confirm your site renders as expected. For more information, see https://help.github.com/articles/updating-your-markdown-processor-to-kramdown.

@peternewman
Copy link
Contributor Author

Interesting, I've not had those on my branch @Arachnid , just messages that the pid.codes domain is already used.

I'll try and update this to use kramdown then.

@Arachnid
Copy link
Contributor

Arachnid commented Dec 9, 2016

Thanks! Will the missing extensions break anything?

@peternewman
Copy link
Contributor Author

Yes, it puts me back to square one with the autolinking:
gettalong/kramdown#306

Which is rather frustrating, as they work fine in the markdown direct on GitHub, e.g.:
https://github.com/peternewman/pidcodes.github.com/blob/master/org/misfittech/index.md
Compare to:
https://peternewman.github.io/pidcodes.github.com/org/misfittech/

Given it doesn't do what it says on the tin, I'm not sure how many other features don't match the direct markdown rendering within GitHub. :(

@Arachnid
Copy link
Contributor

Arachnid commented Dec 9, 2016

Bugger. Thanks again for your hard work on this, though.

@peternewman peternewman changed the title Turn on the remaining redcarpet extensions so we match GitHub Switch the markdown engine to kramdown as GitHub are getting rid of redcarpet :( Dec 10, 2016
@peternewman
Copy link
Contributor Author

I guess this probably wants merging if it keeps GitHub happy, even if it is a step backwards in my opinion.

@Arachnid Arachnid merged commit f7a7695 into pidcodes:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants