Validate token decimals in initializer.

pie-dao · Sep 14, 2020 · f2400b5 · f2400b5
1 parent c2fbe8f
commit f2400b5
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/contracts/Crust.sol b/contracts/Crust.sol
@@ -16,6 +16,7 @@ contract Crust is IMiniMeToken {
         require(_crumbs.length > 0, "Crust.constructor: Crust must at least have one crumb");
         for(uint256 i = 0; i < _crumbs.length; i ++) {
             crumbs.push(IMiniMeToken(_crumbs[i]));
+            require(crumbs[i].decimals() == _decimals, "Crumbs must have same number of decimals as crust");
         }
         name = _name;
         symbol = _symbol;
@@ -64,4 +65,12 @@ contract Crust is IMiniMeToken {
         }
         return result;
     }
+
+    /**
+    * @notice Gets the amount of decimals.
+    * @dev Necesary because otherwise typechain does not generate working artifacts
+    */
+    function decimals() external view returns(uint8) {
+        return decimals;
+    }
 }
diff --git a/contracts/interfaces/IMiniMeToken.sol b/contracts/interfaces/IMiniMeToken.sol
@@ -1,6 +1,7 @@
 pragma solidity 0.4.24;
 
 interface IMiniMeToken {
+    function decimals() external view returns(uint8);
     function balanceOf(address _account) external view returns(uint256);
     function balanceOfAt(address _account, uint256 _block) external view returns(uint256);
     function totalSupply() external view returns(uint256);

diff --git a/test/crust.ts b/test/crust.ts
@@ -60,6 +60,21 @@ describe("Pie Crust", function () {
         // TODO make this test show up in the coverage report. (Low priority)
     });
 
+    it("Test token decimals", async() => {
+        const token2 = await (new MiniMeTokenFactory(signers[0])).deploy(
+            constants.AddressZero,
+            constants.AddressZero,
+            0,
+            "TKN2",
+            8,
+            "TKN2",
+            true
+        );
+        // Using chai-as-promised because waffle chai matchers seem not to be working with constructors
+        // @ts-ignore
+        await expect((new CrustFactory(signers[0])).deploy([token0.address, token1.address, token2.address], "TEST", "TEST", 18)).to.be.rejectedWith("VM Exception while processing transaction: revert Crumbs must have same number of decimals as crust")
+    });
+
     it("Test balance of", async() => {
         await token0.generateTokens(account, parseEther("1337"));
         expect(await crust.balanceOf(account)).to.eq(parseEther("1337"));