Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'roundrect' shapes in configurations returned by 'game_systems()' #226

Closed
trevorld opened this issue Jun 19, 2020 · 1 comment
Closed

Support 'roundrect' shapes in configurations returned by 'game_systems()' #226

trevorld opened this issue Jun 19, 2020 · 1 comment
Assignees
@trevorld
Labels
enhancement New feature or request

Comments

@trevorld
Copy link
Member

@trevorld trevorld added the enhancement New feature or request label Jun 19, 2020
@trevorld
Copy link
Member Author

trevorld commented Sep 2, 2020

Should probably not used "roundrect" by default:

  • rounded rectangle shape seems to increase 3D rendering time
  • would probably lead to larger file sizes in vectorized file formats
  • harder to cut print-and-play components
  • currently rgl chockes

So should offer it instead as an argument to game_systems()

@trevorld trevorld self-assigned this Sep 2, 2020
trevorld added a commit that referenced this issue Jun 23, 2021
@trevorld
fix: Use 'readobj::read.obj' as backup for 'rgl::readOBJ'
1528658 
* This should fix 'piece3d()' bug when drawing
  'roundrect' and 'meeple' shapes (#226)
  if the development version of 'readobj' is installed
@trevorld trevorld mentioned this issue Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorld trevorld

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevorld