-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "End Shape" Prop & Introduces "Circle" Option #111
Conversation
This looks awesome. |
Hey! This looks brilliant! I'll need some time to review it. Sorry for not being very active at the moment. Thank you for the great work 😊 |
I just read your whole PR, I don't have much to add. This is amazing 😊 The one thing missing I can think of is the update of typescript definitions 😊 |
@pierpo - No worries about the delay! OSS is tough - thank you for what you do! Thank you for the feedback. I apologize for such a large PR, but I couldn't think of an easy way to break this down into small pieces without a breaking change that wasn't useful... I've updated the TS definitions in 2ea43fa. Please let me know if you see anything missing, wrong or needing documentation, I'll be happy to address it! Finally, is there anything you'd like me to do as far as incrementing the version, tagging the branch, etc. in order to prepare a new release? |
I wouldn't have imagined something shorter either so no worries 😊
Thank you!
No worries, I'll handle this. I'll try to do it in the following days! |
Just to give you some news: I'm quite busy at the moment, I'll get back to it probably next week. Thank you for the great work and for your patience 😊 |
Sorry I still haven't found the time (despite my promise). I really want to publish this next week! I'll merge in the mean time so that any further contribution includes your changes. Thank you for the amazing job I really appreciate the help 😊 |
This PR does 2 things:
arrowLength
andarrowThickness
props into a newendShape
propcircle
option to theendShape
prop (and creates the ability to add additional shapes in the future)This PR addresses #39. It also paves the way for #79 (we could introduce a
startShape
object).Note: This would be a major version change as I've changed the API.
Current Implementation
New/Updated Implementation
New/Updated Implementation (with circle)
Screenshots