Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable typeface for PDF preview or export #18

Closed
vekuda opened this issue Mar 20, 2019 · 6 comments
Closed

Customizable typeface for PDF preview or export #18

vekuda opened this issue Mar 20, 2019 · 6 comments
Labels
feature A feature that should or is being worked on
Milestone

Comments

@vekuda
Copy link

vekuda commented Mar 20, 2019

Personally I am fine with Courier Prime, but superlou's 'fountain' extension for Atom also allows to pick Anonymous Pro, Courier Code or GNU Typewriter... it could be a useful feature to have.

@piersdeseilligny piersdeseilligny added the feature A feature that should or is being worked on label Mar 21, 2019
@piersdeseilligny piersdeseilligny added this to the 1.3.0 milestone Apr 11, 2019
@piersdeseilligny
Copy link
Owner

I don't really want to embed a limited set of fonts into betterfountain, as it would be a lot more elegant to just use system fonts. However pdfkit doesn't currently support this (as it doesn't know where to look for the .ttf files associated with a font name). So this feature is currently on hold.

@piersdeseilligny piersdeseilligny removed this from the 1.3.0 milestone Apr 13, 2019
@piersdeseilligny
Copy link
Owner

image

Looks like I talked too fast...

piersdeseilligny added a commit that referenced this issue Apr 13, 2019
@piersdeseilligny piersdeseilligny added this to the 1.3.0 milestone Apr 13, 2019
@vekuda
Copy link
Author

vekuda commented Apr 13, 2019

Are you telling me that you managed to add this feature?

Also my congratulations (and many thanks) for having added auto-add CONT'D!

@piersdeseilligny
Copy link
Owner

@vekuda yup, it will be in 1.3.0. It's probably still slightly buggy, but it works.

And what do you mean auto-add CONT'D? I haven't added it yet.

@vekuda
Copy link
Author

vekuda commented Apr 13, 2019

Ah, I had seen it in the milestone, but I didn't notice that it was still open.

So how is this typeface feature supposed to work? Will it use OS fonts or a bunch of built-in fonts?

@piersdeseilligny
Copy link
Owner

It will use os fonts, including autocomplete and an in-editor error if the font can't be found:

I got the PDF export working by using a really cool npm module called font-finder which allows me to point pdfkit to the correct files based simply off the name of the font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature that should or is being worked on
Projects
None yet
Development

No branches or pull requests

2 participants