Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ffmpeg binaries to 4.2.1 #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

yafp
Copy link

@yafp yafp commented Dec 10, 2019

I downloaded the ffmpeg 4.2.1 binaries for

  • win32
  • win64
  • mac64
  • linux32
  • linux64

and replaced your old versions with it.
No other changes made.
URL sources are provided with the single commits.

Changes are not tested but i hope this helps updating your nice project.

Sideeffect:
Version 4.2.1 seems a lot bigger than the 3.x versions you are currently using.

@pietrop
Copy link
Owner

pietrop commented Dec 13, 2019

Thanks, I'll see if I can make some time to test it out (at least the mac version) before merging.

Where did you download the binaries from?

I was also looking at your issue yafp/media-dupes#22 and that's an excellent point re size of the repository over time, by committing binaries into it.

I run into a similar problem in another repository where I wrote this ADR to explore some options

if the binaries are from github releases of some other repository could follow option "5. npm pre install with wget"

@yafp
Copy link
Author

yafp commented Dec 13, 2019

Hi @pietrop

regarding your question:

I used the source urls which you provided in your project readme.md
I've added the urls for each binary to the commit messages (open by clicking ...) - to make it as clear as possible

@pietrop
Copy link
Owner

pietrop commented Dec 13, 2019

Awesome, thank you soo much @yafp !

@yafp
Copy link
Author

yafp commented Dec 13, 2019

@pietrop
Regarding having not all 5 binaries in the builds .... i guess i found a pretty easy solution. Its not fully tested so far but it seems to work.

It's about adding a files section to the platform specific section of your package.json. This can be used to ignore some path while running electron-builder.

See yafp/media-dupes#22 for an example

@pietrop
Copy link
Owner

pietrop commented Dec 13, 2019

@yafp yes, exactly! that's what I described in this blog post which is how I did it in autoEdit and BBC Digital Paper Edit (Electron)

@yafp
Copy link
Author

yafp commented Jan 24, 2020

@pietrop
any chance you already played around with those updated binaries?

@derhuerst
Copy link

Let's solve this upstream! See also eugeneware#35 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants