Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existsFile and bump the version. #15

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

swanhtet1992
Copy link
Contributor

No description provided.

@pietroppeter pietroppeter merged commit ad0b891 into pietroppeter:master Feb 12, 2023
@pietroppeter
Copy link
Owner

Thanks! Will tag the release now!

@pietroppeter
Copy link
Owner

had to fix CI but now it is tagged and released

@swanhtet1992
Copy link
Contributor Author

had to fix CI but now it is tagged and released

Yeah, I saw it failed and looked for what is needed to be fixed today. As I am not familiar with github workflow, couldn't help.

Thanks for a great library btw. I am learning Nim and your codes help a lot.

@swanhtet1992 swanhtet1992 deleted the patch-1 branch February 13, 2023 16:37
@pietroppeter
Copy link
Owner

Thanks for a great library btw. I am learning Nim and your codes help a lot.

you are welcome! that is very nice to hear! This library is actually the first thing I did in nim so code might not be great and I have not worked a lot on this (it could definitely use some love...). Feel free to ask other stuff either here (discussions) or on discord or on nimib discussion (the project I am most involved) or nim forum...

Yeah, I saw it failed and looked for what is needed to be fixed today. As I am not familiar with github workflow, couldn't help.

it was actually tricky, I clicked on the red X for the failed CI (still accessible from list of commits: https://github.com/pietroppeter/nimoji/commits/master) and there I clicked on details and arrived here: https://github.com/pietroppeter/nimoji/actions/runs/4157331624/jobs/7191757615
there I saw that there was a problem with the action I use to setup nim (https://github.com/jiro4989/setup-nim-action) so I just updated to a recent release (I actually just did that on nimib repo, pietroppeter/nimib#169, so I was fresh on the matter...).
Also something that changed is that the I think the way the CI is shown changed on github (CI was added a few commits ago but the green/red check appears only from your commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants