Removing BuildProvider dependency given it does not work in M1 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piever
requested changes
Nov 30, 2022
| @@ -4,17 +4,17 @@ authors = ["Pietro Vertechi"] | |||
| version = "0.3.2" | |||
|
|
|||
| [deps] | |||
| BinaryProvider = "b99e7846-7c00-51b0-8f62-c81ae34c0232" | |||
| CodecZlib = "944b1d66-785c-5afd-91f1-9de20f533193" | |||
There was a problem hiding this comment.
The new dependencies also need compatibility information (the [compat] field below).
|
|
||
| BinaryProvider.gen_unpack_cmd(joinpath(tmp, "katex.tar.gz"), tmp) |> run | ||
| katex_compressed=joinpath(download_dir, "katex.tar.gz") |
There was a problem hiding this comment.
Suggested change
| katex_compressed=joinpath(download_dir, "katex.tar.gz") | |
| const katex_compressed = joinpath(download_dir, "katex.tar.gz") |
| @@ -12,9 +12,16 @@ download( | |||
| const tmp = joinpath(_pkg_assets, "tmp") | |||
| !isdir(tmp) && mkdir(tmp) | |||
|
|
|||
| download("https://github.com/KaTeX/KaTeX/releases/download/v0.10.0/katex.tar.gz", joinpath(tmp, "katex.tar.gz")) | |||
| const download_dir = joinpath(_pkg_assets, "download") | |||
There was a problem hiding this comment.
Could the download also happen inside tmp? Maybe it can be split as tmp/download and tmp/extract. I find it cleaner to just remove one tmp folder at the end
|
I've changed the settings of the repo, so now the CI runs when you push changes here. It may be necessary to increase the lower bound of julia compatibility to be able to use the Tar.jl package. |
|
Superseded by #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing BuildProvider dependency given it does not work in M1. Instead using Tar and CodecZlib.