Possibility of passing configs to Literate.markdown via Remark.slideshow #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piever
requested changes
Nov 30, 2022
| @@ -4,17 +4,17 @@ authors = ["Pietro Vertechi"] | |||
| version = "0.3.2" | |||
|
|
|||
| [deps] | |||
| BinaryProvider = "b99e7846-7c00-51b0-8f62-c81ae34c0232" | |||
There was a problem hiding this comment.
This seems like a change from #53, so it shouldn't be in this PR. Same for many of the changes below.
There was a problem hiding this comment.
Indeed that is the case. Will close this PR.
| @@ -24,7 +24,7 @@ const depfiles = joinpath.(_pkg_assets, depnames) | |||
| const style_css = joinpath(_pkg_assets, "style.css") | |||
|
|
|||
| function slideshow(presentation_dir; | |||
| title="Title", documenter=true, options=Dict()) | |||
| title="Title", documenter=true, options=Dict(), kwargs...) | |||
There was a problem hiding this comment.
I confess I'm not too keen on forwarding all keywords indiscriminately to Literate. Could we require the user to pass a config dict here instead? Maybe it can just be an additional literate_options=Dict() keyword argument?
This should also be documented in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added kwargs to pass configs to Literate.markdown from Remark.slideshow call.