Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL Support #21

Merged
merged 39 commits into from
Feb 17, 2019
Merged

GraphQL Support #21

merged 39 commits into from
Feb 17, 2019

Conversation

hallee
Copy link
Member

@hallee hallee commented Feb 17, 2019 •
edited
Loading

Closes #5

This PR adds support for GraphQL POST queries, page-based pagination, and adds a GraphQL playground to /graphql.

I intended to implement cursor pagination but this would require building an opaque cursor implementation from scratch.

I also intend to eventually support automatic persisted queries.

hallee and others added 30 commits February 3, 2019 06:57
@hallee
Very WIP GraphQL controller
d63985c
@hallee
Working hello world query
8812d2a
@hallee
Won't need Graphiti
b206d76
@hallee
Neat conversion from SupportedType to GraphQLType
bc7778e
@hallee
Schema creation from ContentCategory
3b9b320
@hallee
GraphiQL
8ff3078
@hallee
Improved camelCase and PascalCase conversion
b61f4ec
@hallee
Fixed schema creation to match types, still very basic
4cb3481
@hallee
Nonnull if required
95ecdeb
@hallee
Naive "nodes" structure
e830ca7
@hallee
Work toward resolving actual nodes values
6b88c82
@hallee
Small fix
b0a852b
@hallee
As it turns out, no
95f3d40
@hallee
tried and failed to wrangle types
ef1d83a
@hallee
Wow it's actually working
f7477bb
@hallee
Wow, must be a way to do this with only 1 query
8d49d26
@hallee
Much closer to a single database query; need to memcache a bit
9e21676
@hallee
Async. Reduced to a query for each content type, still too many
97a8c2d
@hallee
Played with graphiti, but back to plain graphql
d12abce
@hallee
Potentially cleaner resolver structure
b72080a
@hallee
Cleaner fetch method with todo
c944cd1
@hallee
Pagination skeleton
ab8c06e
@hallee
Check in Package.resolved
484e55f
@hallee
Cleanup
e78e9b1
@hallee
Edges as a list
f487f21
@hallee
Remove need to pass in request; can use eventLoopGroup directly
e5bee54
@hallee
Doh. No need for another query; items passed in resolver
8467ba2
@hallee
Resolvers for edges
ff9041b
@hallee
Replaced graphiql with graphql playground
eb28c6d
@hallee
defaultValue must be a string 🤔
474f33b
@hallee hallee merged commit b88bbfb into master Feb 17, 2019
@hallee hallee deleted the graphql branch February 17, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hallee