feat(chips): add alarm control panel chip #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
approved these changes
Feb 17, 2022
Also remove old log and enable color even for not active alarm panel (ie disarmed).
|
For the translation, if the key is not present in the file, it will fallback to english so it's not a problem 🙂 |
piitaya
reviewed
Feb 17, 2022
| @@ -92,7 +92,7 @@ alarm_control_panel: | |||
| - alarm_control_panel.alarm_panel_1 | |||
| - alarm_control_panel.alarm_panel_2 | |||
| disarm: | |||
| service: alarm_control_panel.alarm_arm_home | |||
| service: alarm_control_panel.alarm_disarm | |||
zsarnett
reviewed
Feb 17, 2022
| @@ -105,7 +105,7 @@ export class ChipsCardEditorChips extends LitElement { | |||
| ${CHIP_LIST.map( | |||
| (chip) => html` | |||
| <paper-item data-type="${chip}" } | |||
There was a problem hiding this comment.
I would recommend moving away from Paper Drop down menus. I know this was not changed in this PR but something to think about.
HA frontend is moving out all paper Drop downs and that means the component will no longer be loaded. We have moved to mwc-select
There was a problem hiding this comment.
Thanks for pointing that, I'll create a tech issue.
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alarm control panel that displays icon and color like the card.
Also added chip name translation, if PR is validated, we have to update translations in #130
fix #105