-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set min light brightness to 1 #848
base: main
Are you sure you want to change the base?
Conversation
This could also be implemented as an extra switch in the light card to choose between 0% or 1% as a minimum if that is more desirable. |
I think it must |
I'm not sure I follow what you mean; the icon is already clickable, right? |
With Home Assistant Tile card, you can assign different action for icon and info |
Maybe I'm misunderstanding you, but changing the tap action is already possible in Mushroom, right? Or is your point that some users might have changed the tap action and use swipe to turn off the light? |
Mushroom has tap actions for the whole card (outside of the slider) In any case, @piitaya I don't really see the dependency to that, since mushroom already has even more (3) actions (Tap, Hold, Double Tap), so users can still configure any of those 3 to toggle (which is the default anyway). No?
That is of course a risk, but it could be announced as a Breaking change and users can re-configure any of the 3 actions to toggle? |
Ah, thanks for the clarification |
@piitaya Is it hard to add support for mushroom cards to allow icon click? Maybe you have timeline when it will be available in mushroom? |
When will this fix be applied to the release..? ;-) |
What is blocking this fix right now? Is it that this change has have an option for the card to set min/max for the slider to avoid breaking changes? |
Description
This PR updates the light brightness slider such that it goes down to 1% instead of 0%. See related issue for reasoning.
Related Issue
This PR fixes or closes issue: fixes #847
Motivation and Context
Allows setting a light to its lowest brightness without turning it off
How Has This Been Tested
New code has been compiled and added to HA as described in the README under Manual
Types of changes
Checklist