Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requries-python to pyproject.toml #1376

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Add requries-python to pyproject.toml #1376

merged 1 commit into from
Jul 13, 2022

Conversation

gopackgo90
Copy link
Contributor

Adding the Python version requirements of the project helps tools like pip decide if a given version of the package is appropriate to install with a given Python version.

Proposed Changes

Please describe the big picture of your changes here to communicate to
the Pika team why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a
much lower chance of being accepted.

If English isn't your first language, don't worry about it and try to
communicate the problem you are trying to solve to the best of your
abilities. As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask on the
pika-python
mailing list. We're here to help! This is simply a reminder of what we
are going to look for before merging your code.

  • [ x] I have read the CONTRIBUTING.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further Comments

If this is a relatively large or complex change, kick off the discussion
by explaining why you chose the solution you did and what alternatives
you considered, etc.

Adding the Python version requirements of the project helps tools like `pip` decide if a given version of the package is appropriate to install with a given Python version.
@lukebakken lukebakken added this to the 1.3.1 milestone Jul 12, 2022
@lukebakken lukebakken self-assigned this Jul 12, 2022
Copy link
Member

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukebakken lukebakken merged commit 0cd119a into pika:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants