Use getaddrinfo to get ipv6 working #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've improved #309 solution by using getaddrinfo. In this way I get the first result got by getaddrinfo and use the resulting data to select if to use ipv6 or ipv4 as network protocol based on the input address. I've removed socket.has_ipv6 since it could return true also without ipv6 connection nor ipv6 dns resolving.
|
A next step would be to loop trough all the returned address found by getaddrinfo and try to connect to each one |
I've wrapped the line as your advice, thanks
gmr
pushed a commit
that referenced
this pull request
Mar 28, 2013
Use getaddrinfo to get ipv6 working
|
Thanks! |
|
No problem, I had to update the code a bit, with your patch you would only try and connect on the first IP address resolved and if RabbitMQ was not listening on IPv6 but the hostname resolved to both an IPv4 and IPv6 address (like localhost on my machine) it would fail. I appreciate the patch, it sent me in the right direction! |
|
Just seen the code, seems perfect now ;) Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've improved #309 solution by using getaddrinfo.
In this way I get the first result got by getaddrinfo and use the resulting data to select if to use ipv6 or ipv4 as network protocol based on the input address.
I've removed socket.has_ipv6 since it could return true also without ipv6 connection nor ipv6 dns resolving.