Jython and recursive fix #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran extensive tests over multiple days using multiple RabbitMQ servers to test the recursive fix and not had a single issue. The only issue encountered was towards my server in Tokyo, but that was due to an insufficient socket timeout. I experienced the same problem in the current master. So not related to these fixes. In fact I would recommend that we increase the default timeout. |
|
Thanks! |
This was referenced Feb 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two fixes.
It fixes Issue #370 and #286.
The Jython fix should be solid. The recursion fix on the other-hand could be solved on a deeper level. As I don't know the exact behavior behind this change, but based on my testing it has only had a positive effect.
If the recursive fix is not to your liking I can make a separate pull request with only the Jython fix.