-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSLError event processing. #501
Conversation
Poll for events using select. Catch socket timeout exception. Do not try to use IOLoop to handle socket events. Remove unused class variable DO_HANDSHAKE.
It seems there's another bug handling ssl.SSL_ERROR_WANT_READ in _handler_error(). Current behaviour is to disconnect immediately. I seem to be having all sorts of strange disconnect behaviour running on weak 3G connection. |
Update IOLoop event handler on SSL_ERROR_WANT_READ or SSL_ERROR_WANT_WRITE. Update event_state flags only if SSLError does not occur.
Sure if you can make it work that way, but the current behaviour is to loop eternally doing the handshake and never return control back to running the IOLoop. The other problem was not catching socket exceptions during handshake, which is not handled well by the caller. |
Any plans getting this to master? It has been working fine for me. Using standard select() during initial handshake doesn't seem like a big issue to me. |
Using |
Closing due to not using native adapters for behavior which seems wrong. Thanks for your patch. If you want to (and it's still needed), please resubmit without the select based implementation, based upon current master. |
Do not try to use IOLoop to handle socket events.
Poll for events using select.
Catch socket timeout exception.
Remove unused class variable DO_HANDSHAKE.