Socket improvements #505
Closed
Socket improvements #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling shutdown() avoids wait for garbage collection to free system resources.
|
I like this, but need to cherry pick stuff since not all of it applies anymore. I'll credit you but commit the changes directly in my own branch. |
gmr
added a commit
that referenced
this pull request
Apr 29, 2015
This is directly taken from #505 but I could not cleanly merge it due to cleanup and some post-PR refactoring. Thanks @ kherrala
| if self.socket: | ||
| try: | ||
| self.socket.shutdown(socket.SHUT_RDWR) | ||
| except socket.error as err: |
There was a problem hiding this comment.
No point for as err, since err is not used
|
@kherrala, that's a good point about dependency on garbage-collection. I wasn't aware of this socket subtlety in python. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most important fix here is to stop processing events if socket is closed during error on handle_read or handle_write. It also seems like previous check for closed socket should not be checking for method parameter fd.
Calling socket.shutdown() was inspired by this:
http://engineering.imvu.com/2014/03/06/charming-python-how-to-actually-close-a-socket-by-calling-shutdown-before-calling-close/