Fixed BlockingConnection handling of server-initiated Connection.Close as well as of sudden loss of connection with broker #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kingConnection._check_state_on_disconnect raises ConnectionClosed. This supplements the previously-merged PR pika#450 by getting the connection into consistent state. Fix pika#540 - fix handling of Connection.Close in BlockingConnection._on_connection_closed that was preventing ConnectionClosed from being raised.
vitaly-krugl
changed the title
|
Very strange situation with coverall failure here: my test only added about 5 lines of code, so I don't see why it's unhappy. |
|
Thanks for the PR, I'll take a look ASAP. |
…hod() and log ConnectionClosed in BlockingConnection._on_connection_closed()
vitaly-krugl
pushed a commit
to vitaly-krugl/pika
that referenced
this pull request
Apr 13, 2015
This was referenced Apr 13, 2015
Merged
|
LGTM, thanks |
gmr
added a commit
that referenced
this pull request
Apr 29, 2015
…-lost-connection Fixed BlockingConnection handling of server-initiated Connection.Close as well as of sudden loss of connection with broker
vitaly-krugl
referenced
this pull request
Apr 29, 2015
- Just use the normal check state on disconnect - Make some methods static - Avoid redeclaring variables used in module scoped imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #541 - Make sure connection state is properly reset when BlockingConnection._check_state_on_disconnect raises ConnectionClosed. This supplements the previously-merged PR #450 by getting the connection into consistent state.
Fixed #540 - fix handling of Connection.Close in BlockingConnection._on_connection_closed that was preventing ConnectionClosed from being raised.
Also, together with PR #533, this should address #412