add on_close_callback support for TwistedProtocolConnection #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zephor5
changed the title
|
Thank you for your submission. Please accompany your submission with a test that verifies your change. |
Current coverage is 82.54%@@ master #718 diff @@
=====================================
Files 19 19
Lines 3409 3409
Methods 0 0
Branches 536 536
=====================================
Hits 2814 2814
Misses 463 463
Partials 132 132
|
vitaly-krugl
requested changes
Jun 13, 2017
|
these commits are not neat, close this and reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is