New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure process_data_events returns #887

Merged
merged 2 commits into from Oct 28, 2017

Conversation

Projects
None yet
2 participants
@lukebakken
Contributor

lukebakken commented Oct 27, 2017

In certain scenarios process_data_events does not return to allow start_consuming() to return

Fixes #885

Code to reproduce: repro.py.txt

Ensure process_data_events returns
In certain scenarios process_data_events does not return to allow start_consuming() to return

@lukebakken lukebakken requested review from michaelklishin and gmr Oct 27, 2017

@lukebakken lukebakken added this to the 0.11.1 milestone Oct 27, 2017

@lukebakken

This comment has been minimized.

Contributor

lukebakken commented Oct 27, 2017

@radzhome - if you have a chance to check out this PR, I would appreciate it. Thanks!

@codecov

This comment has been minimized.

codecov bot commented Oct 27, 2017

Codecov Report

Merging #887 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   81.96%   81.94%   -0.02%     
==========================================
  Files          21       21              
  Lines        3732     3734       +2     
  Branches      554      554              
==========================================
+ Hits         3059     3060       +1     
- Misses        522      523       +1     
  Partials      151      151
Impacted Files Coverage Δ
pika/adapters/blocking_connection.py 83.92% <50%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7ecc4...d6397cf. Read the comment docs.

@michaelklishin michaelklishin merged commit 7022aa9 into master Oct 28, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukebakken lukebakken deleted the gh-885 branch Oct 29, 2017

gbartl pushed a commit to gbartl/pika that referenced this pull request Jan 27, 2018

Merge pull request pika#887 from pika/pikagh-885
Ensure process_data_events returns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment