Ensure large numbers are encoded correctly #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #861 The struct module throws struct.error when attempting to encode a greater-than-4-byte number using the "i" (4 byte) format. This will catch the error and promote the encoding to "q" (8 byte) format.
|
I'm not thrilled with catching |
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 81.94% 81.99% +0.04%
==========================================
Files 21 21
Lines 3734 3743 +9
Branches 554 554
==========================================
+ Hits 3060 3069 +9
Misses 523 523
Partials 151 151
Continue to review full report at Codecov.
|
michaelklishin
approved these changes
Nov 9, 2017
gbartl
pushed a commit
to gbartl/pika
that referenced
this pull request
Jan 27, 2018
Ensure large numbers are encoded correctly
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #861
The struct module throws
struct.errorwhen attempting to encode a greater-than-4-byte number using the "i" (4 byte) format. This will catch the error and promote the encoding to "q" (8 byte) format.