Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap unicode decode errors when data is not valid utf-8 #890

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

lukebakken
Copy link
Member

Fixes #769

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #890 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   81.94%   81.88%   -0.07%     
==========================================
  Files          21       21              
  Lines        3734     3743       +9     
  Branches      554      554              
==========================================
+ Hits         3060     3065       +5     
- Misses        523      527       +4     
  Partials      151      151
Impacted Files Coverage Δ
pika/data.py 80.57% <66.66%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7022aa9...ca5bf0a. Read the comment docs.

@michaelklishin michaelklishin merged commit 572acdc into master Nov 9, 2017
@lukebakken lukebakken deleted the gh-769 branch November 9, 2017 15:23
@lukebakken lukebakken added this to the 0.11.1 milestone Nov 9, 2017
gbartl pushed a commit to gbartl/pika that referenced this pull request Jan 27, 2018
Trap unicode decode errors when data is not valid utf-8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants