pika.compat should be a module, not package

[lukebakken]

Fixes the issue raised here:

#945 (comment)

[codecov]

Codecov Report

Merging #978 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #978   +/-   ##
======================================
  Coverage    82.5%   82.5%           
======================================
  Files          19      19           
  Lines        3779    3779           
  Branches      567     567           
======================================
  Hits         3118    3118           
  Misses        508     508           
  Partials      153     153

Impacted Files	Coverage Δ
pika/compat.py	84.31% <ø> (ø)
pika/adapters/blocking_connection.py	85.75% <0%> (-0.28%)	⬇️
pika/adapters/base_connection.py	64.86% <0%> (+0.77%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173ce21...48d8339. Read the comment docs.

[vitaly-krugl]

Looks good. But I didn't quite understand why the package compat didn't work in #945. Would you mind elaborating?

[anton-ryzhov]

@vitaly-krugl because distutils installs only packages listed under packages keyword in setup.py. compat.py was a part of pika package, but compat/__init__.py is a new pika.compat package, different than just pika.
If you add new [sub]packages, you must list it in setup.py. Or use http://setuptools.readthedocs.io/en/latest/setuptools.html#using-find-packages

[vitaly-krugl]

because distutils installs only packages listed under packages keyword

So, one option was to list compat/__init__.py in setup.py instead of turning it into compat module? Just curious.

[anton-ryzhov]

Yes, sure, like this:

setuptools.setup(
    …
    packages=['pika', 'pika.adapters', 'pika.compat'],
    …
)

or even better (autodiscovery):

from setuptools import find_packages

setuptools.setup(
    …
    packages=find_packages(exclude=['*.tests', '*.tests.*', 'tests.*', 'tests']),
    …
)

[lukebakken]

@vitaly-krugl apologies that I missed your question and thank you @anton-ryzhov for answering it.

[vitaly-krugl]

Thanks @anton-ryzhov!

@lukebakken - I like the find_packages() recommendation for auto-discovery. What do you think?

[lukebakken]

I doubt Pika will add packages in the future. The issue around compat was all my mistake in thinking it had to be a package.