Add a few more URLParameters tests #994
Conversation
| self.assertEqual(parameters.virtual_host, | ||
| pika.URLParameters.DEFAULT_VIRTUAL_HOST) | ||
|
|
||
| def test_uses_default_virtual_host_via_encoded_slash_2(self): |
There was a problem hiding this comment.
I think it may be better to use more descriptive test names instead of suffixing with 1,2,3,4. It seems like the variability is upper case vs lower case encoding and terminating slash versus no terminating slash.
@daryasary, could you please provide a simple example that reproduces the issue that you tried to fix with #993? |
|
@lukebakken, could you please take a look at the software installation failures that caused a number of the build jobs to fail? This may be related to the changes in PR #984. Perhaps software installations could use some hardening or a faster source repository. |
|
It looks like Erlang Solutions' package repository is slow. |
Is there a cache site that might be faster, more reliable? |
|
I'll try using the default Erlang package. |
|
The default Erlang package for Ubuntu Trusty is too old to use ( |
rename tests Upgrade to RMQ 3.7.4, do not use ESL package
Add a few more URLParameters tests (cherry picked from commit 16cca34)
I tried to reproduce what was reported in #993, but couldn't, but added a few more tests.