-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partial request responses #794
Fix partial request responses #794
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/i4pir6s3b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, since this is locked to only affect requests that send a "RANGE" header, I feel fairly confident that this won't affect other existing requests. Do you have a demo app that you're using to test locally, with an mp4 or some other video file?
61e70d6
to
4e8b3ba
Compare
This also fixes some issues with etags and sending binary files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Allows the dev server to handle partial (
range
) requests. Fixes #755I'm currently unsure how this may affect other requests. I will be looking into a bit more but wanted to get this out here for visibility.