Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nginx setup for centos #292

Merged
merged 7 commits into from
Apr 6, 2023
Merged

fix nginx setup for centos #292

merged 7 commits into from
Apr 6, 2023

Conversation

mariusa
Copy link
Contributor

@mariusa mariusa commented Mar 24, 2023

No description provided.

@rcarmo
Copy link
Member

rcarmo commented Mar 24, 2023

Regarding editing nginx.conf, that may not be the best way to go about it. We are using sites-enabled/default right now, and I'm checking if adding a separate entry in sites-enabled/piku.conf works OK for a few use cases.

@rcarmo
Copy link
Member

rcarmo commented Mar 24, 2023

Yep, you only need to do this: piku/cloud-init@90024bc

@mariusa
Copy link
Contributor Author

mariusa commented Mar 24, 2023

Nice! That isn't on centOS though, looking for an equivalent.

From https://serverfault.com/questions/527630/difference-in-sites-available-vs-sites-enabled-vs-conf-d-directories-nginx
It's important to note that sites-available|sites-enabled is a Debian-ism and is not something that nginx or Apache do. It was probably quite useful in the past, but its utility is somewhat limited in an age of configuration management and containers.

@mariusa
Copy link
Contributor Author

mariusa commented Mar 24, 2023

updated with proper setup:
echo "include /home/piku/.piku/nginx/*.conf;" > /etc/nginx/conf.d/piku.conf

@rcarmo
Copy link
Member

rcarmo commented Mar 24, 2023

Well, I run Fedora on most of my desktops… There are no absolutes in configuration approaches.

@mariusa
Copy link
Contributor Author

mariusa commented Mar 25, 2023

I run Fedora on most of my desktops

me too :)

The PR is updated and ready to merge.

@rcarmo rcarmo merged commit 4306aad into piku:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants