-
Notifications
You must be signed in to change notification settings - Fork 145
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI Notifications ignore locale #1059
Comments
Thanks for reporting. You're right, the localization is incomplete and changes are required in various places. I can partially fix that, but please watch out for other notifications which also need translation. |
Thanks for the fast response.
|
Thanks! It will difficult to localize all of them as some notifications are mapped log messages which are currently not localized. I'll be able to handle the connection-related events at least, such as "no connection", "reconnecting", and a few more buried in the code. |
Hi again, Does it have anything to do with your changes or is it just a random bug? |
Are you sure the flipswitch had German labels before applying the changes? Note, some plugins like led-light and milight-reloaded use custom UI templates which are not properly localized. |
I am sure it had german labels. I temporarily fixed it by setting the xOn and xOff Label in the device settings, but I still can't see in your changes why those labels changed their strings |
ok, may be I forgot to commit one of the generated files. I'll check |
I think this is working now, however, localization is far from being complete. Please re-open if you still have issues with localized device labels |
The notifications on the webui after switching a device on or off are not translated and not even listed in the locale files.
They say "switching off" and "done" no matter what you've set your locale to.
I haven't found the js file that creates these notifications, cause that sounds like a simple fix.
Maybe you can add locale support for these notifications or simply tell me the files that create these?
The text was updated successfully, but these errors were encountered: