Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI Notifications ignore locale #1059

Closed
Unkn0wn-MDCLXIV opened this issue Mar 13, 2017 · 8 comments
Closed

WebUI Notifications ignore locale #1059

Unkn0wn-MDCLXIV opened this issue Mar 13, 2017 · 8 comments

Comments

@Unkn0wn-MDCLXIV
Copy link
Contributor

The notifications on the webui after switching a device on or off are not translated and not even listed in the locale files.
They say "switching off" and "done" no matter what you've set your locale to.
I haven't found the js file that creates these notifications, cause that sounds like a simple fix.

Maybe you can add locale support for these notifications or simply tell me the files that create these?

@mwittig
Copy link
Collaborator

mwittig commented Mar 13, 2017

Thanks for reporting. You're right, the localization is incomplete and changes are required in various places. I can partially fix that, but please watch out for other notifications which also need translation.

mwittig added a commit to pimatic/pimatic-mobile-frontend that referenced this issue Mar 13, 2017
@Unkn0wn-MDCLXIV
Copy link
Contributor Author

Unkn0wn-MDCLXIV commented Mar 14, 2017

Thanks for the fast response.
The 'done' and switching messages are translated now.
There are still a few notifications that seem hardcoded, I list a few up that I've spotted so far:

  • exiting, flushing to disk etc. on shutdown

  • rendering theme

  • reconnecting, could not connect

  • Oops, no connection popup

  • loading (with indicator)

@mwittig
Copy link
Collaborator

mwittig commented Mar 14, 2017

Thanks! It will difficult to localize all of them as some notifications are mapped log messages which are currently not localized. I'll be able to handle the connection-related events at least, such as "no connection", "reconnecting", and a few more buried in the code.

@Unkn0wn-MDCLXIV
Copy link
Contributor Author

Hi again,
I've applied your changes to my pimatic installation.
After restarting I noticed, that my flipswitch labels are in english now, saying "Off" and "On".

Does it have anything to do with your changes or is it just a random bug?

@mwittig
Copy link
Collaborator

mwittig commented Mar 15, 2017

After restarting I noticed, that my flipswitch labels are in english now, saying "Off" and "On".

Are you sure the flipswitch had German labels before applying the changes? Note, some plugins like led-light and milight-reloaded use custom UI templates which are not properly localized.

@Unkn0wn-MDCLXIV
Copy link
Contributor Author

Unkn0wn-MDCLXIV commented Mar 16, 2017

I am sure it had german labels.
I'm only using the shell-execute plugin.

I temporarily fixed it by setting the xOn and xOff Label in the device settings, but I still can't see in your changes why those labels changed their strings

@mwittig
Copy link
Collaborator

mwittig commented Mar 16, 2017

ok, may be I forgot to commit one of the generated files. I'll check

@mwittig
Copy link
Collaborator

mwittig commented Jan 2, 2018

I think this is working now, however, localization is far from being complete. Please re-open if you still have issues with localized device labels

@mwittig mwittig closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants