Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] JS Errors on Bricks with many-to-many relation and specific configuration #462

Conversation

robertSt7
Copy link
Contributor

resolves #406

@robertSt7 robertSt7 added the Bug label Mar 13, 2024
@robertSt7 robertSt7 added this to the 1.4.1 milestone Mar 13, 2024
@robertSt7 robertSt7 changed the base branch from 1.x to 1.4 March 13, 2024 14:20
@robertSt7 robertSt7 modified the milestones: 1.4.1, 1.4.2, 1.4.3 Apr 23, 2024
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@herbertroth herbertroth modified the milestones: 1.4.3, 1.4.4 Jun 4, 2024
@lukmzig lukmzig self-assigned this Jun 14, 2024
@lukmzig
Copy link
Contributor

lukmzig commented Jun 14, 2024

@robertSt7 this will not resolve the existing error right? So if there is existing configuration it will still throw an error. (but I guess we cannot really do anything here as this should not be allowed in the first place)
I also tried a drag a fieldset from the existing field container and then back into the field container` and I got a JS error which then broke the UI.
Screenshot from 2024-06-14 09-49-45

Can you have a look?

Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertSt7 seems like issue was only present on my installation. I will merge the PR

@lukmzig lukmzig merged commit 2347505 into 1.4 Jun 17, 2024
6 checks passed
@lukmzig lukmzig deleted the 406-bug-js-errors-on-bricks-with-many-to-many-relation-and-specific-configuration branch June 17, 2024 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] JS Errors on Bricks with many-to-many relation and specific configuration
4 participants