Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Childs to Children to align with Pimcore 6 #59

Closed
NiklasBr opened this issue Jun 17, 2019 · 1 comment · Fixed by #60
Closed

Change Childs to Children to align with Pimcore 6 #59

NiklasBr opened this issue Jun 17, 2019 · 1 comment · Fixed by #60
Assignees
@NiklasBr
Projects
v0.2 ("Cacofonix")

Comments

@NiklasBr
Copy link
Contributor

NiklasBr commented Jun 17, 2019 •
edited
Loading

With the update to Pimcore 6 the getChilds() methods and childs attributes (among some other) have changed to the more proper children. Doing the same here would be nice,

I'm preparing a PR.
@weisswurstkanone
Copy link
Contributor

thx!

@NiklasBr NiklasBr mentioned this issue Jun 17, 2019
Merged
@weisswurstkanone weisswurstkanone moved this from To do to In Progress in v0.2 ("Cacofonix") Jun 18, 2019
v0.2 ("Cacofonix") automation moved this from In Progress to Done Jun 18, 2019
weisswurstkanone added a commit that referenced this issue Jun 18, 2019
@weisswurstkanone
Change Childs to Children to align with Pimcore 6 #59
b2419af
weisswurstkanone added a commit that referenced this issue Jun 18, 2019
@weisswurstkanone
Change Childs to Children to align with Pimcore 6 #59
cbe5f89
shamoh19 pushed a commit to shamoh19/data-hub that referenced this issue Nov 12, 2021
@fashxp
Improvements for Classification Store Support (pimcore#59)
6255f87 
* [Classification Store Improvements] docs

* [Classification Store Improvements] array support for date

* [Classification Store Improvements] (input) quantity value array operator

* [Classification Store Improvements] (input) quantity value array operator

* [Classification Store Improvements] (input) quantity value array operator

* [Classification Store Improvements] keep sub arrays option for explode operator

* [Classification Store Improvements] translations

* [Classification Store Improvements] docs

* Apply php-cs-fixer changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasBr NiklasBr

Labels
None yet
Projects
No open projects
v0.2 ("Cacofonix")
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renames 'childs' to 'children'
2 participants
@NiklasBr @weisswurstkanone