Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose: use new docker tags #369

Merged
merged 3 commits into from
Oct 27, 2022
Merged

docker-compose: use new docker tags #369

merged 3 commits into from
Oct 27, 2022

Conversation

brusch
Copy link
Member

@brusch brusch commented Oct 19, 2022 •
edited

@brusch brusch added this to the 10.2.4 milestone Oct 19, 2022
@brusch brusch added the Task label Oct 19, 2022
@brusch brusch mentioned this pull request Oct 21, 2022
Merged
kingjia90
kingjia90 requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the README.md needs to be changed as well

demo/README.md

Line 33 in 9348b6d

``docker run -u `id -u`:`id -g` --rm -v `pwd`:/var/www/html pimcore/pimcore:PHP8.0-fpm composer create-project pimcore/demo my-project``

@brusch
Copy link
Member Author

brusch commented Oct 25, 2022

@kingjia90 thanks, done! 👍

@dvesh3 dvesh3 merged commit 4a6d78d into 10.2 Oct 27, 2022
@dvesh3 dvesh3 deleted the docker_new_tags branch October 27, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjia90 kingjia90 kingjia90 approved these changes

@aashan10 aashan10 aashan10 approved these changes

Assignees

@aashan10 aashan10

Labels
Task
Projects
None yet
Milestone
10.2.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brusch @kingjia90 @aashan10 @dvesh3